Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update defaults for API #33

Merged
merged 2 commits into from
Jun 17, 2024
Merged

docs: Update defaults for API #33

merged 2 commits into from
Jun 17, 2024

Conversation

PhilinTv
Copy link
Contributor

@PhilinTv PhilinTv commented Jun 13, 2024 •
edited
Loading

Oryx Frontend comes with flexible API adapters.

@PhilinTv PhilinTv added the documentation Improvements or additions to documentation label Jun 13, 2024
@PhilinTv PhilinTv requested a review from a team as a code owner June 13, 2024 10:40
PhilinTv
PhilinTv commented Jun 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@tolerants
Copy link
Contributor

Looks good but there are two small issue with PR title and PR summary:

  • It looks more like a docs commit type for me, not chore.
  • Also we shouldn't put BREAKING CHANGE line in case there are no breaking changes as long as automation will detect it and threats this change as a Major.

@PhilinTv PhilinTv changed the title chore: Update defaults for API doc: Update defaults for API Jun 14, 2024
@tolerants tolerants changed the title doc: Update defaults for API docs: Update defaults for API Jun 14, 2024
@PhilinTv PhilinTv merged commit d85f5e8 into development Jun 17, 2024
14 of 17 checks passed
@PhilinTv PhilinTv deleted the PhilinTv-patch-1 branch June 17, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolerants tolerants tolerants approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.5 - Public Open Source release
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilinTv @tolerants