-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Added product variants feature #46
Draft
tobi-or-not-tobi
wants to merge
18
commits into
development
Choose a base branch
from
feature/variants
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5f29b45
render product variantions
tobi-or-not-tobi c111876
fix tsconfig
tobi-or-not-tobi 3b6dcb4
only normalize variants if there are at least 2
tobi-or-not-tobi bc87a9e
fix includes
tobi-or-not-tobi 4942f8f
fix: fix varaiants for list
supproduction 518f93f
Merge branch 'feature/variants' of https://github.com/oryx-frontend/o…
supproduction ca93a6e
Merge pull request #41 from supproduction/feature/variants
tobi-or-not-tobi 4fb7bd6
Merge branch 'development' into feature/variants
tobi-or-not-tobi 428bb64
formatting
tobi-or-not-tobi fb23cb3
formatting
tobi-or-not-tobi 1dbb2fa
normalize variant data
tobi-or-not-tobi 032021c
highlight variant attribute feature
tobi-or-not-tobi 247b00b
variant list component
tobi-or-not-tobi 2796757
improve product page data
tobi-or-not-tobi 24a73db
Disable unavailable variants
tobi-or-not-tobi ba65090
refactor name
tobi-or-not-tobi 394e074
Merge branch 'development' into feature/variants
tobi-or-not-tobi c5c5ed8
improved colors
tobi-or-not-tobi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,11 @@ | ||
export interface ProductAttributesOptions { | ||
columnCount?: string; | ||
/** | ||
* Highlighted variant attributes will clarify the uniqueness of the value among | ||
* the variants. If the attribute is unqieu to the variant, a highlight attribute | ||
* is added, so that the stylesheet can mark the attribute value. | ||
* | ||
* @since 1.5 | ||
*/ | ||
highlightVariantAttribute?: boolean; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export * from './variant-selector.component'; | ||
export * from './variant-selector.styles'; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we providing parsing anywaay can we just move specifiv variantDefinition into variants object?