Wizard: add Filesystem customization test (HMS-5967) #3263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksiekl
commented
May 26, 2025
| await newPageAutomatic.waitForLoadState(); | ||
| const finalUrlAutomatic = newPageAutomatic.url(); | ||
| expect(finalUrlAutomatic).toContain( | ||
| 'https://docs.redhat.com/en/documentation' |
There was a problem hiding this comment.
Idk if I should put in the whole URL, or just check that it goes to the documentation ❓
ksiekl
commented
May 26, 2025
| const size = frame | ||
| .getByRole('gridcell', { name: '1', exact: true }) | ||
| .getByPlaceholder('File system'); | ||
| await expect(size).toHaveValue('1'); |
There was a problem hiding this comment.
This check seems....silly. Is there any other way to find this element than by its placeholder and value?
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #3263 +/- ##
=======================================
Coverage ? 84.67%
=======================================
Files ? 187
Lines ? 23521
Branches ? 2455
=======================================
Hits ? 19916
Misses ? 3586
Partials ? 19 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New test that checks the Filesystem customization. Wasn't sure about some stuff - helping comment would be appreciated!