fix: x86 fstat testcase fail #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
api/src/imp/fs/stat.rs:134
- The st_size field type changed from u64 to i64; please verify that this signed conversion correctly handles file sizes and won't introduce overflow issues with large values.
st_size: stat.st_size,
api/src/imp/fs/stat.rs:71
- [nitpick] The updated padding field names (__pad1, __pad2) differ from those in the x86_64 struct; consider standardizing the naming scheme across architectures to improve code clarity.
pub __pad1: u64,
| @@ -8,7 +8,7 @@ use starry_core::task::{time_stat_from_kernel_to_user, time_stat_from_user_to_ke | |||
| use syscalls::Sysno; | |||
|
|
|||
| #[register_trap_handler(SYSCALL)] | |||
| fn handle_syscall(tf: &TrapFrame, syscall_num: usize) -> isize { | |||
| fn handle_syscall(tf: &mut TrapFrame, syscall_num: usize) -> isize { | |||
There was a problem hiding this comment.
The function now accepts a mutable TrapFrame without an accompanying comment explaining why mutations are needed. Please add documentation to clarify this design choice.
Copilot uses AI. Check for mistakes.
Azure-stars
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.