-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganise interpolation code #2597
Conversation
Use the same update mechanism as for updates on the interpolations themselves. Updates must solely happen in place_insert as this is the place where actual changes of the data happen.
Do not index 'inactive' rows (with startnumber is null) where possible.
Nodes on an interpolation now only get the address tags of interpolations and then compute their own parent from that. They no longer inherit the parent directly.
This replaces the interpolationtype column.
The new code uses the open-ended array notation which is only available sind psql 9.6.
Was the error in the data (osm-search/TIGER-data#20) or how Nominatim import processed it? |
The error was in Nominatim's import script. This line is the fix: https://github.com/osm-search/Nominatim/pull/2597/files#diff-451ca5369069426705d525b5819dce5c19e520c143ff8e1de1813717daa8d388R40 |
Great. ST_REVERSE is much easier to call than reversing the raw WKT in python. I'll still implement it somehow but first needs more tests. |
Postgres 9.6 has reached EOL since November 2021. Shouldn't we aim for a supported version? |
The rule is to update the requirements as necessary. EOL versions fall out of support when either a) the CI cannot test them anymore or b) they do not offer a function we'd like to use. In this particular case, PG 9.5 does not have support for open-ended array subscripts. |
This cleans up large parts of the code around interpolations for both the OSM interpolation ways in
location _property_osmline
and the TIGER data inlocation_property_tiger
:addr:interpolation
although the usage is so rare that it doesn't really matter.This PR also fixes a long-standing bug in the TIGER data import, where the start and end housenumbers are potentially switch to make sure that the start number is smaller than the end number but the interpolation geometry was not reversed. Thus results on such lines would be in the wrong order. If you make heavy use of TIGER housenumber data (i.e. search full addresses in the US a lot) you might want to reimport the TIGER data to fix the tables.
Raises the minimum required PostgreSQL version to 9.6.