Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rush #10611

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Rush #10611

wants to merge 3 commits into from

Conversation

peternewman
Copy link
Collaborator

@peternewman peternewman added needs wikidata It is necessary to create a Wikidata item for the entry add brand Actionable - add a brand to the index labels Feb 23, 2025
peternewman
peternewman commented Feb 23, 2025
View reviewed changes
data/brands/shop/hairdresser.json Outdated
Comment on lines 776 to 778
"brand": "Rush",
"brand:wikidata": "",
"name": "Rush",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what exactly the brand/name should be, might need to double-check one, they seem to go by various names on their website:
https://www.rush.co.uk/

I guess I'll need match names for the ones we don't pick too:
Rush Hair & Beauty Salon
Rush Hairdresser

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I created the Wikidata item, I went with "Rush Hair & Beauty" as the title (brand) and "Rush Hairdressers" as an alias (as that seems to be the name of each individual salon). The chain's social media accounts all have usernames with some variation of Rush Hair & Beauty, so I assume they consider that to be their brand as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two shops I've seen are Rush Hair or more specifically:

RUSH
HAIR

But I don't think I've seen the newline elsewhere, I'm less clear if we should use the capitals or not?

@Snowysauce Snowysauce removed the needs wikidata It is necessary to create a Wikidata item for the entry label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snowysauce Snowysauce Snowysauce left review comments

Assignees
No one assigned
Labels
add brand Actionable - add a brand to the index
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peternewman @Snowysauce