ignition-msgs5 5.10.0

[osrfbuild]

No description provided.

[jennuine]

build bottle

[jennuine]

build bottle

[scpeters]

@jennuine sometimes these builds fail for flaky reasons, but it's often worth looking at the console output to see why they failed. For example, the first build failed in the osx_catalina job:

• https://build.osrfoundation.org/job/generic-release-homebrew_triggered_bottle_builder/881/label=osx_catalina/console

==> brew install --verbose --build-bottle osrf/simulation/ignition-msgs5
==> FAILED
==> Downloading https://github.com/gazebosim/gz-msgs/commit/914e7a3b5988d64824805a36877baad87474a81a.patch?full_index=1
Already downloaded: /Users/jenkins/Library/Caches/Homebrew/downloads/09389248f038f2b15f18aea3ab2500cba436e75727df4bc65b21394019e22c7a--914e7a3b5988d64824805a36877baad87474a81a.patch
==> Verifying checksum for '09389248f038f2b15f18aea3ab2500cba436e75727df4bc65b21394019e22c7a--914e7a3b5988d64824805a36877baad87474a81a.patch'
==> Downloading https://osrf-distributions.s3.amazonaws.com/ign-msgs/releases/ignition-msgs5-5.10.0.tar.bz2
Already downloaded: /Users/jenkins/Library/Caches/Homebrew/downloads/1f8e54cd6db09d099bea33c8a816c29296fb69b2cfe215823b3a014d37492b91--ignition-msgs5-5.10.0.tar.bz2
==> Verifying checksum for '1f8e54cd6db09d099bea33c8a816c29296fb69b2cfe215823b3a014d37492b91--ignition-msgs5-5.10.0.tar.bz2'
==> Installing ignition-msgs5 from osrf/simulation
tar --extract --no-same-owner --file /Users/jenkins/Library/Caches/Homebrew/downloads/1f8e54cd6db09d099bea33c8a816c29296fb69b2cfe215823b3a014d37492b91--ignition-msgs5-5.10.0.tar.bz2 --directory /private/tmp/d20220718-36543-1fwbzwa
cp -pR /private/tmp/d20220718-36543-1fwbzwa/ignition-msgs-5.10.0/. /private/tmp/ignition-msgs5-20220718-36543-ezhpdr/ignition-msgs-5.10.0
chmod -Rf +w /private/tmp/d20220718-36543-1fwbzwa
==> Patching
cp -p /Users/jenkins/Library/Caches/Homebrew/downloads/09389248f038f2b15f18aea3ab2500cba436e75727df4bc65b21394019e22c7a--914e7a3b5988d64824805a36877baad87474a81a.patch /private/tmp/ignition-msgs5--patch-20220718-36543-1qzs1at/914e7a3b5988d64824805a36877baad87474a81a.patch
==> Applying 914e7a3b5988d64824805a36877baad87474a81a.patch
patch -g 0 -f -p1 -i /private/tmp/ignition-msgs5--patch-20220718-36543-1qzs1at/914e7a3b5988d64824805a36877baad87474a81a.patch
patching file src/Generator.cc
Hunk #1 FAILED at 67.
1 out of 1 hunk FAILED -- saving rejects to file src/Generator.cc.rej
patching file src/Generator.hh
Hunk #1 FAILED at 44.
1 out of 1 hunk FAILED -- saving rejects to file src/Generator.hh.rej

I added a patch to this formula very recently in #1960 from a pull request that had already been merged to ign-msgs5 but not yet released. This was needed to rebuild the bottle after a new version of protobuf was released in homebrew-core (#1860). The patch needs to be removed in this PR, as it no longer applies properly.

[scpeters]

The patch needs to be removed in this PR, as it no longer applies properly.

patch removed in 871daf5

[scpeters]

it should work now

build bottle

[scpeters]

would it be helpful if we added this discussion to the troubleshooting section in the README of this repo?

• https://github.com/osrf/homebrew-simulation/blob/master/README.md

[jennuine]

would it be helpful if we added this discussion to the troubleshooting section in the README of this repo?

• https://github.com/osrf/homebrew-simulation/blob/master/README.md

Possibly but I don't think I would have figured out the correct fix was removing the patch by looking at the console messages. Maybe we can be explicit and say "...if you see a patch error... check recently closed PRs where a patch may have been done.." and link your comment as an example?