In the vrx simulation, the ocean is currently detected by the lidar. … #796
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where it is expected that the majority of lidar hits are absorbed by water. This patch adds a visibility_filter tag to the 3d lidar that will filter water hits, more closely matching the expected behaviour in the field.
|
This addresses issue #753 |
JMANY42
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… where it is expected that the majority of lidar hits are absorbed by water. Generally only wakes and waves will cause hits.
This patch adds a visibility_filter tag to the 3d lidar that will filter water hits, more closely matching the expected behaviour in the field. The corresponding tag is already present in the water mesh.