Skip to content

ADD: SRv6 SID NLRI #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 9, 2025
Merged

ADD: SRv6 SID NLRI #2892

merged 10 commits into from
Mar 9, 2025

Conversation

Azunyan19
Copy link
Contributor

  • ADD: SRv6 SID NLRI (https://datatracker.ietf.org/doc/rfc9514/)
    • SRv6 SID Information TLV
    • Multi-Topology Identifier TLV
  • FIX: Existing BGP-LS Implementations
    • LsAddrPrefix Length
    • Recognize local-bgp-router-id as IPv4
    • Remove unused function (parseLsLinkProtocol())
    • Remove unused argument from parseLsArgs()
    • Sort BGP-LS TLVs
      • Add GetLsTLV() method to get LsTLVType from []LsTLVInterface
      • Please point out if GetLsTLV() is unnecessary

watal and others added 3 commits March 7, 2025 18:29
Co-authored-by: Taisei Tanabe <[email protected]>
Co-authored-by: Shuto Masuda <[email protected]>
Co-authored-by: Taisei Tanabe <[email protected]>
Co-authored-by: Shuto Masuda <[email protected]>
Co-authored-by: Yuta Fukagawa <[email protected]>
Co-authored-by: Taisei Tanabe <[email protected]>
@watal
Copy link
Contributor

watal commented Mar 8, 2025

Usage Examples:

  • Registering a route:
gobgp global rib add -a ls srv6sid bgp identifier 0 local-asn 65000 local-bgp-ls-id 0 local-bgp-router-id 192.168.255.1 local-bgp-confederation-member 1 sids fd00::1 multi-topology-id 1
  • Checking routes:
gobgp global rib -a ls
   Network                                                                                Next Hop             AS_PATH              Age        Attrs
*> NLRI { SRv6SID { LOCAL_NODE:  SRv6SID: {SIDs: fd00::1} MultiTopo: {MultiTopoIDs: 1}} } 0.0.0.0                                   00:00:26   [{Origin: ?}]

@fujita
Copy link
Member

fujita commented Mar 8, 2025

Usage Examples:

  • Registering a route:
gobgp global rib add -a ls srv6sid bgp identifier 0 local-asn 65000 local-bgp-ls-id 0 local-bgp-router-id 192.168.255.1 local-bgp-confederation-member 1 sids fd00::1 multi-topology-id 1
  • Checking routes:
gobgp global rib -a ls
   Network                                                                                Next Hop             AS_PATH              Age        Attrs
*> NLRI { SRv6SID { LOCAL_NODE:  SRv6SID: {SIDs: fd00::1} MultiTopo: {MultiTopoIDs: 1}} } 0.0.0.0                                   00:00:26   [{Origin: ?}]

Can you add the above to docs directory?

@watal watal force-pushed the master branch 2 times, most recently from eb667e3 to 7e5cf53 Compare March 8, 2025 02:55
watal and others added 4 commits March 8, 2025 12:29
Co-authored-by: Yuta Fukagawa <[email protected]>
Co-authored-by: Taisei Tanabe <[email protected]>
Co-authored-by: Shuto Masuda <[email protected]>
Co-authored-by: Taisei Tanabe <[email protected]>
Co-authored-by: Shuto Masuda <[email protected]>
@watal
Copy link
Contributor

watal commented Mar 8, 2025

@fujita
I've finished the documentation.
082d8e2

I renamed lib-ls.md to bgp-ls.md and updated it to explain both using GoBGP as a daemon and as a library.

The command execution examples are based on the following PRs:

I have also fixed a bug in the previous output.

gobgp global rib -a ls
   Network                                                                                                                                              Next Hop             AS_PATH              Age        Attrs
*> NLRI { SRv6SID { LOCAL_NODE: {ASN: 65000, BGP LS ID: 0, BGP ROUTER ID: 192.168.255.1} SRv6_SID: {SIDs: fd00::1} MULTI_TOPO_IDs: {MultiTopoIDs: 1}} } 0.0.0.0                                   00:00:08   [{Origin: ?}]

@watal watal force-pushed the master branch 2 times, most recently from c7cfcd4 to 4a7e8e5 Compare March 8, 2025 15:04
@watal
Copy link
Contributor

watal commented Mar 8, 2025

I removed the markdownlint errors and renamed lib-ls.md to bgp-ls.md in the ci.yml.

@watal
Copy link
Contributor

watal commented Mar 9, 2025

@fujita fix the embedded workflow error, the following was done:

  • Updated build_embedded_go.py:
      1. Added a flag to target only Go snippets in markdown.
      1. Added validation for multiple Go snippets.
      1. Added an error for missing Go snippets.
  • Corrected the typo from "embeded" to "embedded."

@fujita fujita merged commit a0f653d into osrg:master Mar 9, 2025
39 checks passed
@fujita
Copy link
Member

fujita commented Mar 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants