Replace geoip database support with maxminddb #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll need to figure out a better way to find it before actually creating a PR for this.
|
They added uniquely identified downloads @ end of last year, any concern with tracking/privacy? |
|
@sempervictus Not from me. It's up to the user to consider that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former geoip databases are no longer maintained, but libmaxminddb is. So switch to this.
Currently the output is limited to the country iso code. I haven't tried very hard to get state/province information, but this can be added if it's desired (I don't see a lot of use in it personally, but I'm not opposed to adding it).
I've only tested with the
GeoLite2-Country.mmdbdatabase.The
<geoipdb>configuration setting has been re-used for this.If the database file cannot be opened, an error is logged. Should it exit as well?