Add support for optional package lists for feeds #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qinusty
commented
Apr 30, 2021
Qinusty
commented
Apr 30, 2021
Qinusty
force-pushed
the
qinusty/critical-packages
branch
2 times, most recently
from
f41c06b
to
90e3d12
Compare
Qinusty
force-pushed
the
qinusty/critical-packages
branch
2 times, most recently
from
31951b9
to
2a5607e
Compare
Closed
tom--pollard
reviewed
May 5, 2021
tom--pollard
reviewed
May 5, 2021
tom--pollard
reviewed
May 5, 2021
Qinusty
force-pushed
the
qinusty/critical-packages
branch
3 times, most recently
from
17eb48d
to
6528aa4
Compare
tom--pollard
reviewed
May 7, 2021
This allows feeds to be configured with options (starting with packages) which acts as a list of packages to poll with the intention of avoiding lossy firehose feeds. This is currently implemented for pypi.
Qinusty
force-pushed
the
qinusty/critical-packages
branch
from
6528aa4
to
9754607
Compare
tom--pollard
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows feeds to be configured with a set of packages to poll. In the case of certain feeds, this can help avoid lossy behaviour by ensuring the latest updates from those specific packages are checked during polling.
Support for this option is currently implemented in pypi and an error is reported when attempting to configure other feeds with this unsupported option.
Partially resolves #83