Skip to content

add Dotp cost and corresponding test #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025
Merged

add Dotp cost and corresponding test #615

merged 3 commits into from
Apr 11, 2025

Conversation

marcocuturi
Copy link
Contributor

corresponds to 0.5 * SqEuclidean cost without norms.

Simple test in Sinkhorn comparing to Hungarian output was missing, tested the cost there.

@marcocuturi marcocuturi requested a review from michalk8 April 11, 2025 14:30
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.17%. Comparing base (9ae02ea) to head (9821844).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ott/geometry/costs.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   87.17%   87.17%   -0.01%     
==========================================
  Files          75       75              
  Lines        7761     7767       +6     
  Branches      538      538              
==========================================
+ Hits         6766     6771       +5     
- Misses        851      852       +1     
  Partials      144      144              
Files with missing lines Coverage Δ
src/ott/geometry/costs.py 97.05% <83.33%> (-0.23%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@michalk8 michalk8 merged commit d48b83e into main Apr 11, 2025
10 of 11 checks passed
@michalk8 michalk8 deleted the dotp branch April 11, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants