Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update CONTRIBUTING.md #69

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

kiriakos
Copy link
Contributor

@kiriakos kiriakos commented May 3, 2024

  • Remove the R00 prefix matching in the proposed one-liner as it artificially filters out valid matches. We have guideline IDs that start with R1, R2 etc. By only matching for R00 we filter out many valid IDs that could already be taken.
  • Add toc entry that was forgotten in chore(docs): Update CONTRIBUTING.md #67
  • Clarify rule ID structure

Remove the `R00` prefix matching in the proposed one-liner as it artificially filters out valid matches
@kiriakos kiriakos requested a review from cgebken May 3, 2024 15:22
@cgebken cgebken merged commit 77a5a28 into main May 7, 2024
1 check passed
@cgebken cgebken deleted the kiriakos-contributing-id-fix branch May 7, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants