-
Notifications
You must be signed in to change notification settings - Fork 52
Add multimonitor support for movewindow #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
i'm not sure if i have the plugin set up correctly, but it seemingly makes no difference on my machine. I'll try to investigate further |
I can't get it to shift across monitors either. |
Actually I was testing it wrong. It does work, kind of. Focus gets locked into an odd state that doesn't match what's happening visually after a move, and I would like windows placed at matching monitor edges where possible. |
Also a single window can't be moved across monitors. It needs at least 2 for some reason. |
Thanks for retesting @outfoxxed, I should have noted that I have cursor warping enabled with configuration, which avoids the focus issue for me:
|
Marking this as a draft until noted issues are fixed. |
Added changes to detect edge placement, it should now place windows at the correct edge when moving across monitors. |
Ready for another review. |
@theammir I tried to reproduce the issue with hyprsplit but sadly could not - it works as expected. Perhaps you could share your configs in a gist so I could try to reproduce the issue? |
Here's the minimal setup. The plugins are ojasookert/hy3 on
|
@theammir Thank you for providing the minimal configuration. Sadly, I still could not reproduce the issue - the focused window hops monitors perfectly using I have to admit, I am not quite sure what's the expected behaviour of Can you verify that both plugins are up to date? |
@ojasookert Thanks for mentioning Expanding on the description of behaviour I'm experiencing, it comes to this: when moving a window towards the secondary monitor, it moves to the equally-numbered workspace of the primary instead. Similar thing happens when moving downwards. At the same time, no movement occurs at all when both monitors are on equal workspaces or when I'm trying to move the only window of a workspace. Regarding the plugin versions, I do find it really odd how
At this point, I'm not sure what's the issue on my side. Am I missing something? |
Very much looking forward to this. Thank you everyone for working on this and testing. Let me know if another opinion / test could be useful |
@ojasookert thank you! |
Any progress on this? |
This PR makes progress on resolving #162 by enabling
hy3:movewindow
to move focused windows between monitors. While it functions as expected in most cases, it does not always ensure the window is placed exactly at the edge of the next monitor.It has been working well for my personal use cases, but further testing is required to validate its behavior across different setups. Feedback and additional testing would be greatly appreciated!
Looking forward to any insights or suggestions. 🚀