fix(mrc): fix <OnboardingLayout /> #14940
Conversation
rjamet-ovh
requested review from
stif59100,
aboungnaseng-ovhcloud,
kqesar,
frenautvh,
MaximeBajeux,
anooparveti and
JacquesLarique
rjamet-ovh
force-pushed
the
fix/gh-14934
branch
from
a2759e4 to
1890ea6
Compare
rjamet-ovh
force-pushed
the
fix/gh-14934
branch
from
1890ea6 to
2d1433d
Compare
packages/manager-react-components/src/components/templates/onboarding/onboarding.component.tsx
Outdated
Show resolved
Hide resolved
rjamet-ovh
force-pushed
the
fix/gh-14934
branch
from
2d1433d to
32eefc4
Compare
| {description} | ||
| </OdsText> | ||
| )} | ||
| {description} |
There was a problem hiding this comment.
nitpick: I think this can have adverse effect on existing apps if they dont pass description inside an OdsText.
IMO, OdsText must be retained.
There was a problem hiding this comment.
Since it has been decided to allow free composition on the description part of the layout ( description?: React.ReactNode;), it makes no sense to keep an <OdsText /> as a wrapper :
<OdsText>
<div>
<OdsText>...</OdsText>
<OdsText>...</OdsText>
</div>
</OdsText>
It's a small adjustment, and some apps may have to fix their implementation, but it better match the template interface.
There was a problem hiding this comment.
It is a breaking change for Zimbra, so please mention it to trigger the version bump, thank you !
There was a problem hiding this comment.
breaking change mentioned in commit.
- more info: use <OdsButton /> - update css to match design specs ref: 14934 BREAKING CHANGE: Description has to be a react node Signed-off-by: Romain Jamet <[email protected]>
rjamet-ovh
force-pushed
the
fix/gh-14934
branch
from
32eefc4 to
0ce3bfd
Compare
|
developOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
<OdsButton />