feat(core): add useGetNavigationUrl in shell client #14964
Conversation
There was a problem hiding this comment.
Actually, all the app information is available in Shell-context. So, no need to make it async but it can be made synchronous.
There was a problem hiding this comment.
I take a look 👍
There was a problem hiding this comment.
I seen by curiosity.
getURL return string in the basic inplementation : packages/components/ovh-shell/src/plugin/navigation/index.ts
But the problem it's we provide : invokePluginMethod in packages/components/ovh-shell/src/client/shell-client.ts
I don't known if it's possible to remove it
There was a problem hiding this comment.
@tibs245 you mean you want to return a string, more easy to use ?
There was a problem hiding this comment.
not sure to understand how do you want to make it synchronous. @anooparveti how do you make it synchronous ? as @tibs245 said, getUrl use 'invokePluginMethod' we need to wait this promise
aboungnaseng-ovhcloud
force-pushed
the
feat/MANAGER-15760
branch
3 times, most recently
from
3c7e126 to
b224a51
Compare
packages/manager/core/shell-client/src/hooks/useNavigationGetUrl.ts
Outdated
Show resolved
Hide resolved
ref: MANAGER-15760 Signed-off-by: Alex Boungnaseng <[email protected]> Co-authored-by: Thibault Barske <[email protected]>
aboungnaseng-ovhcloud
force-pushed
the
feat/MANAGER-15760
branch
from
b224a51 to
a85c257
Compare
|
ref: MANAGER-15760
developDescription
add useGetNavigationUrl in shell client to avoid duplication
Related