feat(pci.private-registry): edit cidr #15009
Conversation
ref: TAPC-2320 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2320 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2320 Signed-off-by: Pierre-Philippe <[email protected]>
ppprevost
requested review from
chipp972,
ghyenne,
kqesar,
frenautvh,
oalkabouss and
sachinrameshn
and removed request for
a team
github-actions
bot
added
translation required
feature
| vi.mock('@/pages/CIDR/useDatagridContext', async () => ({ | ||
| __esModule: true, | ||
| default: () => ({ | ||
| editActualRow: vi.fn(), | ||
| isDraft: false, | ||
| }), | ||
| })); |
There was a problem hiding this comment.
I think you should prefer do a global mock of the file and then mock only the default export when importing it ?
Also async isn't necessary here
There was a problem hiding this comment.
effectivly we have a test provider and setup on zimbra with all mocks
packages/manager/apps/zimbra/src/utils/test.provider.tsx
packages/manager/apps/zimbra/src/utils/test.setup.tsx
you can do same functional
packages/manager/apps/pci-private-registry/src/components/CIDR/Authorization.component.tsx
Show resolved
Hide resolved
| vi.mock('@/pages/CIDR/useDatagridContext', () => ({ | ||
| __esModule: true, | ||
| default: () => ({ | ||
| removeDraftRow: vi.fn(), | ||
| }), | ||
| })); |
There was a problem hiding this comment.
is the implementation required ?
ppprevost
force-pushed
the
feat/pci-private-registry_edit_tapc-2320
branch
from
7b6ced4 to
303282d
Compare
github-actions
bot
removed
the
has conflicts
|
| @@ -25,19 +25,85 @@ import { useDatagridColumn } from '@/pages/CIDR/useDatagridColumn'; | |||
| import Filters from '@/components/CIDR/Filters.component'; | |||
| import { getRegistryQueyPrefixWithId } from '@/api/hooks/useIpRestrictions'; | |||
| import useDataGridContext from '@/pages/CIDR/useDatagridContext'; | |||
| import { FilterRestrictionsEnum } from '@/types'; | |||
|
|
|||
| const schemaAddCidr = (dataCIDR: string[], isUpdating: boolean) => | |||
There was a problem hiding this comment.
what's about separate schemaAddCidr in a dedicated file ?
There was a problem hiding this comment.
i think better is on a dedicated file for all schema with zod
github-actions
bot
added
the
has conflicts
developDescription
Related