Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(mrc): use internals polyfill instead of mock #15242

Merged
merged 1 commit into from
Feb 10, 2025
Merged

test(mrc): use internals polyfill instead of mock #15242

merged 1 commit into from
Feb 10, 2025

Conversation

tristanwagner
Copy link
Contributor

@tristanwagner tristanwagner commented Jan 31, 2025 •
edited
Loading

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Right now tests will break again if ODS use another method from internals, this will fix it for good

Related

@tristanwagner tristanwagner marked this pull request as ready for review January 31, 2025 14:58
@tristanwagner tristanwagner requested review from a team as code owners January 31, 2025 14:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot added the bug Something isn't working label Jan 31, 2025
@tristanwagner tristanwagner changed the base branch from master to develop January 31, 2025 15:07
@anooparveti anooparveti merged commit c52594a into develop Feb 10, 2025
24 checks passed
@anooparveti anooparveti deleted the fix/mrc-test branch February 10, 2025 14:05
aottr pushed a commit that referenced this pull request Feb 20, 2025
@tristanwagner @aottr
test(mrc): use internals polyfill instead of mock (#15242)
7dd9aba 
Signed-off-by: Tristan WAGNER <[email protected]>
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
@tristanwagner
test(mrc): use internals polyfill instead of mock (#15242)
0201830 
Signed-off-by: Tristan WAGNER <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti approved these changes

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

@aottr aottr Awaiting requested review from aottr aottr was automatically assigned from ovh/team-manager-dev-reactjs

@chipp972 chipp972 Awaiting requested review from chipp972 chipp972 was automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristanwagner @anooparveti @aboungnaseng-ovhcloud