Add --may-exist parameter to addition of ts #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucassdiass Can you please add your Signed-off-by tag to both the commits in this PR ? Please see "git log" to see an example if you're not aware of this tag usage. Thanks |
lucassdiass
force-pushed
the
add_parameter_ts_add
branch
3 times, most recently
from
41076f7
to
690eb6d
Compare
|
@numansiddique sign-off-by tag added |
|
@lucassdiass can you plz rebase ? The recent PR merge introduced some conflicts. |
lucassdiass
force-pushed
the
add_parameter_ts_add
branch
from
690eb6d
to
75086e2
Compare
lucassdiass
force-pushed
the
add_parameter_ts_add
branch
from
a95a189
to
f8d8854
Compare
|
@numansiddique rebased |
|
@lucassdiass Little confused. Your PR has 9 commits ? Why is that ? Can you plz fix it to have just one commit ? |
lucassdiass
force-pushed
the
add_parameter_ts_add
branch
from
f8d8854
to
6a5376c
Compare
Without --may-exist, ovn-ic-nbctl ts-add ts1 could return error and doesn't execute the following steps of function. Signed-off-by: Lucas Vargas Dias <[email protected]>
lucassdiass
force-pushed
the
add_parameter_ts_add
branch
from
1be70b0
to
642df5c
Compare
|
@numansiddique sorry, my mistake in rebase. I fix it and I change pr to just one commit |
|
@lucassdiass Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without --may-exist, ovn-ic-nbctl ts-add ts1 could return error and doesn't execute the following steps of function.
This problem occurs when CENTRAL_COUNT is greater than 1 because create_fake_vms will be called more than once.
Here it's a example to see the problem:
OS_BASE=ubuntu OS_IMAGE=docker.io/library/ubuntu:jammy ENABLE_SSL=no CENTRAL_COUNT=3 GW_COUNT=3 CHASSIS_COUNT=3 ./ovn_cluster.sh start