Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles now are a taglike field #999

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Roles now are a taglike field #999

merged 4 commits into from
Jan 27, 2025

Conversation

spitfire305
Copy link
Collaborator

No description provided.

@spitfire305 spitfire305 requested a review from ilestis January 24, 2025 22:41
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks and missing admin check

lang/en/campaigns.php Outdated Show resolved Hide resolved
resources/views/components/form/role.blade.php Outdated Show resolved Hide resolved
app/Http/Controllers/Campaign/MemberController.php Outdated Show resolved Hide resolved
app/Services/Campaign/MemberService.php Show resolved Hide resolved
@spitfire305 spitfire305 requested a review from ilestis January 27, 2025 14:36
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilestis ilestis merged commit 0892758 into develop Jan 27, 2025
1 of 2 checks passed
@ilestis ilestis deleted the roles-in-a-smarter-way branch January 27, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants