refactor(transformer/decorators): get statement address with GetAddress::address
#9264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #9264 will not alter performanceComparing Summary
|
Merge activity
|
…ess::address` (#9264) Follow-on after #9062. Pure refactor. In all these cases, `class` / `export` is a `Box`, so we can use `class.address()` to get the address, instead of `Address::from_ptr(class.as_ref())`. These 2 both do exactly the same thing, but personally I think it's preferable to avoid `Address::from_ptr` where we can. `Address::GetAddress` always produces a valid, permanent `Address`, whereas `Address::from_ptr` is a bit of a hack and can give you an unreliable `Address` in some cases. If we only use `Address::from_ptr` where we *have* to, it's easier to see where we have a potential sources of bugs.
graphite-app
bot
force-pushed
the
02-21-refactor_transformer_decorators_get_statement_address_with_getaddress_address_
branch
from
ca62ce6 to
f7d95cb
Compare
graphite-app
bot
deleted the
02-21-refactor_transformer_decorators_get_statement_address_with_getaddress_address_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #9062. Pure refactor.
In all these cases,
class/exportis aBox, so we can useclass.address()to get the address, instead ofAddress::from_ptr(class.as_ref()).These 2 both do exactly the same thing, but personally I think it's preferable to avoid
Address::from_ptrwhere we can.Address::GetAddressalways produces a valid, permanentAddress, whereasAddress::from_ptris a bit of a hack and can give you an unreliableAddressin some cases. If we only useAddress::from_ptrwhere we have to, it's easier to see where we have a potential sources of bugs.