Add separate oxide/net-setup service to ensure we come up with basic networking on all images.
#203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citrus-it
reviewed
May 28, 2025
luqmana
force-pushed
the
compliance-net-setup
branch
from
be85579 to
75396a4
Compare
jclulow
requested changes
May 29, 2025
There was a problem hiding this comment.
In general I think anything that isn't specifically related to compliance should have any mention of compliance scrubbed out. We ship the NIC configuration stuff in essentially every image, so I think making it an oxide/ prefix on the FMRI, and removing any mention of compliance, would make it easier to understand the scope.
luqmana
changed the title
oxide/net-setup service to ensure we come up with basic networking on all images.
luqmana
force-pushed
the
compliance-net-setup
branch
2 times, most recently
from
c33b717 to
091c1e3
Compare
luqmana
force-pushed
the
compliance-net-setup
branch
from
091c1e3 to
fa5e12d
Compare
citrus-it
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new service
oxide/net-setupwhich ensures we have an IPv6 link-local address for the NICs corresponding to each instance of the service. Each instance is named after the corresponding NIC driver (e.g.,e1000g,igb,cxgbe).