-
Notifications
You must be signed in to change notification settings - Fork 44
Allow limited inbound ICMP to Nexus, add ICMP type/code filters to firewall rules #8194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FelixMcFelix
wants to merge
18
commits into
main
Choose a base branch
from
felixmcfelix/icmp-for-nexus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f315451
Initial plumbing.
FelixMcFelix 8a33170
More OpteHdl fixups.
FelixMcFelix 38bd2ff
Parity.
FelixMcFelix c5aec33
Merge branch 'main' into felixmcfelix/icmp-for-nexus
FelixMcFelix 283fc56
CRDB didn't like *that* migration.
FelixMcFelix 3d13775
TODO: migration test.
FelixMcFelix da4c157
Merge branch 'main' into felixmcfelix/icmp-for-nexus
FelixMcFelix 29db3dd
Iterating on launch failures.
FelixMcFelix 01f0f4c
`serde_json::from_str` 🫠
FelixMcFelix 3f8d07e
Merge branch 'main' into felixmcfelix/icmp-for-nexus
FelixMcFelix 14804cb
Simple migration query.
FelixMcFelix 983e6b7
An idempotent column rename
FelixMcFelix 3d1a58e
Some control over ICMP allowance.
FelixMcFelix 62a8b3d
Help the deploy job along, a little.
FelixMcFelix 564424f
Last test fixup.
FelixMcFelix 0c19f5f
`fmt`.
FelixMcFelix 32a4914
Renaming, and some serde/integration tests.
FelixMcFelix 6b9fa7a
Self-review
FelixMcFelix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that this needs to be removed as part of merging.