Skip to content

[8/n] [reconfigurator] add target release generation to blueprint #8199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented May 22, 2025

As described in RFD 556, we need this field as a backstop against Nexus overriding a freshly-conducted mupdate.

There is small semantic change here compared to RFD 556, though not one of much consequence:

  • As currently described in RFD 556, Nexus believes it is in control if the target release generation is greater than this field.
  • In this PR, that logic has been changed to greater than or equal to.

This has two advantages:

  1. It aligns somewhat better with the meaning of "minimum".
  2. target_release_minimum_generation no longer needs to be an Option<Generation>; it can be a Generation instead. That's because we always insert a generation 1 in the target_release table as "unspecified", meaning to use the install dataset. So setting this field to generation 1 just means "use the install dataset".

Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
@sunshowers sunshowers changed the title [9/n] [wip] [reconfigurator] add target release generation to blueprint [9/n] [reconfigurator] add target release generation to blueprint May 22, 2025
@sunshowers sunshowers changed the title [9/n] [reconfigurator] add target release generation to blueprint [8/n] [reconfigurator] add target release generation to blueprint May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant