[sled-agent-config-reconciler] Check zone dataset dependencies before starting zones #8219
+863
−472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjstone
approved these changes
May 28, 2025
| ) | ||
| .await?; | ||
|
|
||
| // TODO-john fixme |
There was a problem hiding this comment.
This was a reminder to myself to do #8220 😅. It's removed there.
| @@ -1194,4 +1632,161 @@ mod tests { | |||
|
|
|||
| logctx.cleanup_successful(); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn start_zone_fails_if_missing_root_dataset() { | |||
| // | ||
| // Skipping that for now, follow the normal zone shutdown process | ||
| // _after_ metrics (i.e., shut down and clean up the zone). | ||
| // |
There was a problem hiding this comment.
Is there a way to detect if this happens?
There was a problem hiding this comment.
I'm not sure; most of this comment was lifted verbatim from services.rs (where we similarly didn't do anything for metrics for preexisting zones).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dramatically reduces the work that
ServiceManager::start_omicron_zone()does by moving most of it to the config-reconciler:DatasetConfigs, and we never choose a root zpool since all zones have a property specifying which they should use)Builds on #8064 + #8218.
Fixes #8173.