Skip to content

Add the CRDB HTTP address to DNS, blueprint #8351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: crdb-parse-http-addr
Choose a base branch
from

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jun 17, 2025

This hasn't been strictly necessary in production, because we're re-using the existing CRDB address and just changing the port, but it's necessary for having tests which use "port zero" and receive assignments dynamically.

For a more holistic context, see: nexus/tests/integration_tests/cockroach.rs, where we are now able to access both
the "postgres" and "HTTP" ports via DNS lookup. This will be necessary in subsequent PRs which want to access
this interface to query for Prometheus metrics.

@smklein
Copy link
Collaborator Author

smklein commented Jun 18, 2025

NOTE TO SELF: In ca245f6 , I'm using the "secondary_service_address" part of the blueprint to store the CockroachDB HTTP address.

This seems kinda like it's "Used-as-intended" - if the tests are happy, I really should:

  • Add a schema migration that back-fills existing blueprints in the DB, to contain this address with the fixed port
  • Perhaps add a data migration test for this use-case

@smklein smklein changed the title Add the CRDB HTTP address to DNS Add the CRDB HTTP address to DNS, blueprint Jun 18, 2025
@smklein
Copy link
Collaborator Author

smklein commented Jun 18, 2025

Probably not using this, with preference for #8377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant