Add the CRDB HTTP address to DNS, blueprint #8351
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't been strictly necessary in production, because we're re-using the existing CRDB address and just changing the port, but it's necessary for having tests which use "port zero" and receive assignments dynamically.
For a more holistic context, see:
nexus/tests/integration_tests/cockroach.rs
, where we are now able to access boththe "postgres" and "HTTP" ports via DNS lookup. This will be necessary in subsequent PRs which want to access
this interface to query for Prometheus metrics.