Trust Quorum: Better match protocol in TLA+ spec #8363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the message implementation a bit and the `PersistentState` structure. It adds messages that will be used in follow up PRs, and ensures that `rack_id` is always checked on each message. Furthemore it stores configurations and shares separately inside the persistent state. This allows retrieval of a configuration for stale sled and the recomputation of its own share for that configuration to occur in separate steps. This matches what is done in the TLA+ spec. I also added a comment about the intention of future code coming for the `Node` type. This reflects the experience of implementing LRTQ, and is helpful to simplify testing. If we don't have to track timeouts for arbitrary API requests inside the sans-io code, it becomes much simpler.
andrewjstone
commented
Jun 18, 2025
| @@ -55,24 +55,26 @@ impl CoordinatorState { | |||
| log: Logger, | |||
| now: Instant, | |||
| msg: ValidatedReconfigureMsg, | |||
There was a problem hiding this comment.
msg should return this platforms config and share if easy enough. Then there is no need for the option.
sunshowers
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the message implementation a bit and the
PersistentStatestructure. It adds messages that will be used in follow up PRs, and ensures thatrack_idis always checked on each message. Furthemore it stores configurations and shares separately inside the persistent state. This allows retrieval of a configuration for stale sled and the recomputation of its own share for that configuration to occur in separate steps. This matches what is done in the TLA+ spec.I also added a comment about the intention of future code coming for the
Nodetype. This reflects the experience of implementing LRTQ, and is helpful to simplify testing. If we don't have to track timeouts for arbitrary API requests inside the sans-io code, it becomes much simpler.