Skip to content

Parse prometheus metrics from crdb admin server #8379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: crdb-admin-access
Choose a base branch
from
Open

Parse prometheus metrics from crdb admin server #8379

wants to merge 2 commits into from

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jun 18, 2025 •
edited
Loading

  • Adds a wrapper around the cockroach admin server to query from many backends
  • Parses the output from the admin server (and the underlying CRDB HTTP server)
  • Adds integration tests that validate the data is flowing correctly
  • Adds proptests to validate the parsing works

@smklein smklein changed the title Access prometheus metrics through admin server Parse prometheus metrics from admin server Jun 18, 2025
@smklein smklein changed the title Parse prometheus metrics from admin server Parse prometheus metrics from crdb admin server Jun 18, 2025
@hawkw hawkw self-requested a review June 19, 2025 00:27
@hawkw
Copy link
Member

hawkw commented Jun 19, 2025

tagging myself to take a look at this one as i've worked with Prometheus a bit in a past life :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw Awaiting requested review from hawkw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smklein @hawkw