Added support for device 008-304 (HiSense Window air conditioner) #152
Conversation
| - property: t_beep | ||
| disable: true | ||
| - property: t_eco | ||
| disable: true |
There was a problem hiding this comment.
Does the device expose any of the disabled properties?
There was a problem hiding this comment.
Not that I was able to identify. This is a small room window AC unit with minimal features.
There was a problem hiding this comment.
So can the disabled properties just be deleted from the mapping file? Or are they included in the statusList for the device, but just don't have any effect?
There was a problem hiding this comment.
can be deleted. I was just following how the other files were structured. I've commented them out of my local config and reloaded system without error.
There was a problem hiding this comment.
commited change
|
Thank you for your contribution ❤️ Just left a question in the review. |
oyvindwe
changed the title
…rovements of device.
|
I think it's cleaner to just remove the properties, but I'm happy to merge in any case. Thank you for your contribution! |
This is a hisense Window air conditioner. tested and working within my HA environment