Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Washing machine WPNA84A2TSWIFI/PL #218

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

robs23
Copy link

@robs23 robs23 commented Feb 16, 2025

Adding mapping files for WPNA84A2TSWIFI/PL

@robs23
Copy link
Author

robs23 commented Feb 16, 2025

I still need to add translations for dictionary items I created. 2 questions about that:

  1. From languages already listed in translations dictionary, I know only English. Should I then also be adding e.g. Dutch translations for my dictionary items? I mean, the way I can possibly achieve this is by using machine translations which I won't be able to verify
  2. I could also add Polish language as that's my mother tongue. Should I be translating whole English translation dictionary then? I mean, without the context it can be far from perfect for some items but maybe that's still better than nothing

@oyvindwe
Copy link
Owner

@robs23 Thank you for your contribution! ❤️

  1. From languages already listed in translations dictionary, I know only English. Should I then also be adding e.g. Dutch translations for my dictionary items? I mean, the way I can possibly achieve this is by using machine translations which I won't be able to verify
  2. I could also add Polish language as that's my mother tongue. Should I be translating whole English translation dictionary then? I mean, without the context it can be far from perfect for some items but maybe that's still better than nothing

Only English is required. I am happy to merge PRs for other languages a well. I think it's simpler if you submit a PR per language in that case.

Copy link
Owner

@oyvindwe oyvindwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the new strings to strings.json

@robs23
Copy link
Author

robs23 commented Feb 25, 2025

Gotcha, added

Copy link
Owner

@oyvindwe oyvindwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Seems like the states for status and door_status is missing in strings.json though?

@robs23
Copy link
Author

robs23 commented Feb 27, 2025

Hopefully this time I got everything right..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants