refactor: Operate on statuses through a new StatusRepository #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code to show the notification account filtering dialogs and respond to the user's choices was specific to notification account filters. As additional account filters will be developed make this more general. - Add an enum to specify the timeline affected by the filters. - Pass this, and UX strings, to the dialog dispaying the filtering options. - Rewrite the viewmodel to use actions
TimelineCases is increasingly badly named, as some of these methods operate on statuses irrespective of whether or not they're on a timeline. Move reblog, favourite, and bookmark methods in to a new StatusRepository.
- Migrate timelineCases.voteInPoll - Rename `pinAccount` to correct `pinStatus` - Fix bug in ViewThreadViewModel, optimistic updates were not reverted on failure. - Optimistically update in search results - Rename "setVoted" to "setPoll" to accurately reflect what it does - Add factorys to Moshi in FakeNetworkModule
# Conflicts: # app/src/main/java/app/pachli/components/conversation/ConversationsViewModel.kt # app/src/main/java/app/pachli/components/search/SearchViewModel.kt # app/src/main/java/app/pachli/components/search/fragments/SearchStatusesFragment.kt # app/src/main/java/app/pachli/components/viewthread/ViewThreadViewModel.kt # core/data/src/main/kotlin/app/pachli/core/data/repository/notifications/NotificationsRepository.kt
nikclayton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code operated on statuses either through direct calls to
StatusDaoor via methods exposed inTimelineCases.There probably isn't enough business logic to justify the overhead
of having use-cases for this functionality, so fold that in to a
new
StatusRepositoryand remove some duplicated code.