fix: Handle JSON enums with unknown values #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code expected all incoming enums values to map directly to Kotlin enum constants. This is a problem for servers with additional features -- e.g., "reaction" as a notification type. Fix this with a new Moshi adapter that will set the incoming value to a given constant if it's not recognised. Apply this to the enum constants in core.network to ensure they are handled. Clean up enum handling in Converters.kt, ComposeViewModel.kt, and Status.kt by using the existing `.ordinal` property and some extension functions for idiomatic code. Fixes pachli#461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code expected all incoming enums values to map directly to Kotlin enum constants.
This is a problem for servers with additional features -- e.g., "reaction" as a notification type.
Fix this with a new Moshi adapter that will set the incoming value to a given constant if it's not recognised.
Apply this to the enum constants in core.network to ensure they are handled.
Clean up enum handling in Converters.kt, ComposeViewModel.kt, and Status.kt by using the existing
.ordinalproperty and some extension functions for idiomatic code.Fixes #461