migrate to dart-sass #5215
migrate to dart-sass #5215
Conversation
|
Thanks for your interest in palantir/blueprint, @pgoldberg! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
pgoldberg
force-pushed
the
pgoldberg/migrateToDartSass
branch
from
61f5c5f to
9f8f0d6
Compare
| @@ -17,11 +17,11 @@ | |||
| // keep a trail of hovered items as submenus are opened | |||
| /* stylelint-disable scss/at-extend-no-missing-placeholder */ | |||
| &:not([class*="#{$ns}-intent-"]) { | |||
| @extend .#{$ns}-menu-item:hover; | |||
| @extend .#{$ns}-menu-item, :hover; | |||
There was a problem hiding this comment.
https://sass-lang.com/documentation/at-rules/extend#disallowed-selectors
If
.message.infocould be extended, the definition of@extendsays that elements matching the extender would be styled as though they matched.message.info. That’s just the same as matching both.messageand.info, so there wouldn’t be any benefit in writing that instead of@extend .message, .info.
pgoldberg
force-pushed
the
pgoldberg/migrateToDartSass
branch
from
9f8f0d6 to
c3dcfdd
Compare
| @@ -0,0 +1,40 @@ | |||
| import fs from "fs-extra"; | |||
There was a problem hiding this comment.
the
dart-sassCLI doesn't support custom functions or importers, but the JS API does, so delegate to node
Very frustrating, but basically the only way we can migrate and keep sass-inline-svg and the importer (which allows us to resolve tilde imports outside of webpack), we need to delegate to node
pgoldberg
force-pushed
the
pgoldberg/migrateToDartSass
branch
2 times, most recently
from
37b9b69 to
7d610b7
Compare
pgoldberg
force-pushed
the
pgoldberg/migrateToDartSass
branch
from
d5b2438 to
98b6b51
Compare
|
merged in #5216 |
Will write description soon!
Fixes #0000
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot