Switch from @import to @use #7157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
ggdouglas
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Hey @justinbhopper, thanks for re-introducing this! After a more thorough review, it looks like we still need to address some stylistic changes to elevation styles. Otherwise, the remainder here looks good, and I can approve once we address fixing the elevation classes.
| @@ -1,8 +1,8 @@ | |||
| // Copyright 2015 Palantir Technologies, Inc. All rights reserved. | |||
| // Licensed under the Apache License, Version 2.0. | |||
|
|
|||
| @import "color-aliases"; | |||
| @import "mixins"; | |||
There was a problem hiding this comment.
It looks like updating @import "mixins" here causes the border-shadow mixin to not be available in certain component style files. Particularly, it causes the elevation shadows on Cards and wherever else we use the elevation classes specifically to become malformed.
| Before | After |
|---|---|
 |
 |
| Before | After |
|---|---|
 |
 |
/* `border-shadow` mixin appears in compiled CSS */
.bp5-elevation-4 {
box-shadow: border-shadow(.1), 0 4px 8px rgba(17, 20, 24, .2), 0 18px 46px 6px rgba(17, 20, 24, .2);
}There was a problem hiding this comment.
@ggdouglas Great catch! Somehow, I missed this function usage.
In order to solve this, I had to remove the usage of border-shadow in _variables.css. This is because we can't import a reference to _mixins.scss in this file without creating a circular dependency loop. Since border-shadow is pretty straight forward, I figured it would be fine.
I triple-checked all the other functions and I feel pretty confident this was the only thing I missed. Famous last words? 🤣
There was a problem hiding this comment.
Yeah, I had also noticed the circular dependency between _variables.css and _mixins.scss. Substituting the mixin seems like a reasonable change to me. 👍
ggdouglas
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7031
This PR re-introduces the changes from #7074 and includes fixes to issues mentioned in #7154.
In the original PR, some imports were missed for function calls in a few places. SASS compile did not complain because I guess it assumes they might be native CSS functions.
I have double-checked all function usage to make sure no other imports were missing, and I've compared the results of the docs-app locally to make sure the issues shown in #7154 are resolved.
cc: @ggdouglas
Checklist