move SeedProvider and AbstractNetworkTopologySnitch to InetAddressAndPort for forward compatibility #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Port for forward compatibility
rhuffy
force-pushed
the
rh/inetaddress-and-port
branch
from
0dffd23 to
efbf067
Compare
rhuffy
commented
Aug 28, 2024
Comment on lines
+298
to
+299
|
|
||
| InetAddressAndPort.initializeDefaultPort(getSSLStoragePort()); |
There was a problem hiding this comment.
note that on trunk the default port is getStoragePort() so 7000. I'm not sure if this matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern versions of Cassandra use InetAdderssAndPort in place of InetAddress. To avoid maintaining two implementations of every custom SeedProvider and AbstractNetworkTopologySnitch we use internally, this PR switches some usage of InetAddress to InetAddressAndPort.
This allows us to maintain implementations of SeedProvider and AbstractNetworkTopologySnitch that are compile-time compatible with this fork, and with OSS trunk.