Upgrade conjure-verification version #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoylan
force-pushed
the
bm/upgrade-verifier
branch
from
a52406b to
946cbf9
Compare
bmoylan
commented
Oct 5, 2020
| # This test case is changed in a later verifier version to UNKNOWN_VARIANT which is actually valid. | ||
| # https://github.com/palantir/conjure-verification/pull/114 | ||
| # - "{\"ONE\": \"\", \"TWO\": \"\", \"BAD VARIANT\": \"\"}" | ||
| # Uncomment in go 1.14+ |
There was a problem hiding this comment.
uncomment if we bump go or remove if we do #139 first
tabboud
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is