Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: YAML methods use JSON methods directly #347

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

improvement: YAML methods use JSON methods directly #347

wants to merge 3 commits into from

Conversation

bmoylan
Copy link
Contributor

@bmoylan bmoylan commented Sep 6, 2022 •
edited
Loading

Bypasses some unneeded reflection/processing within encoding/json if we know the type implements the interface(s).

This change is Reviewable

@bmoylan bmoylan requested a review from tabboud October 23, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabboud tabboud Awaiting requested review from tabboud

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmoylan @svc-changelog