Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The
ErrorType
trait had some significant limitations (like the inability to statically retrieve an error type's name string), and retained functionality (like with_instance_id) that hasn't been used in many years.After this PR
==COMMIT_MSG==
Overhauled the
ErrorType
trait. Its methods are now static, allowing easier comparison of the type of a serialized error.==COMMIT_MSG==
When we work out #418, we can add some utility methods to turn a
SerializableError
back into a typed error.Closes #339