promote PreferCommonAnnotations to WARNING

[rhuffy]

Before this PR

Check introduced in #2505. SeverityLevel.SUGGESTION makes it easy to miss.

After this PR

==COMMIT_MSG==
promote PreferCommonAnnotations to WARNING
==COMMIT_MSG==

Possible downsides?

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

promote PreferCommonAnnotations to WARNING

Check the box to generate changelog(s)

• Generate changelog entry

[CRogers]

imports can't be suppressed using @SuppressedWarnings, so this cannot be auto-suppressed. If it had an autofix that worked every time, it would be fine to make this error level. But I don't think this works every time as repos may not have guava as an import (that said, we could make this a "ConditionalPatchCheck" on the presence of guava, which should make it safe).

I don't actually know how suppressible-error-prone behaves with errors on imports - maybe try running this on an internal repo using maven local and see what happens.