failing testcases for safe-logging check when using Runnables/Suppliers/etc #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
I tried to see if I could fix this myself, but I lack the knowledge of this meta-java stuff. I did see in debugger that at this line, the
parameterSafetyis correctlySAFE, and theargumentis an@Unsafe Object value, but then the SafetyAnalysis returns asUNKNOWNleading to the check below passing. But not sure if this is even the correct place to catch it, or if it should rather be caught somewhere else.Also my
//asserts in the test cases might be wrong, but if you remove them, the tests will pass with no errors - which they shouldn't, I think.After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?