Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto formatter #12

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

auto formatter #12

wants to merge 10 commits into from

Conversation

FinlayRJW
Copy link
Contributor

Before this PR

Had no automatic formatting for versions.props files

After this PR

Now we have a formatter that will ensure that versions.props is formatted into the following form:

groupPart1.groupPart2:packageName = version

Possible downsides?

Need to enable formatting on save to access this feature to the fullest - need to add to README

@changelog-app
Copy link

changelog-app bot commented Sep 23, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

auto formatter

Check the box to generate changelog(s)

  • Generate changelog entry

@FinlayRJW FinlayRJW requested a review from crogoz September 26, 2024 14:00
@FinlayRJW FinlayRJW marked this pull request as ready for review September 26, 2024 14:00
@FinlayRJW FinlayRJW requested a review from CRogers October 8, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants