Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mandatory defaults for the dockerfileZip task #483

Closed
wants to merge 8 commits into from
Closed

Set mandatory defaults for the dockerfileZip task #483

wants to merge 8 commits into from

Conversation

rkotkiewicz
Copy link

Before this PR

If we don't apply the distribution plugin, dockerfileZip breaks a build.

After this PR

dockerfileZip don't break builds.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/gradle-docker, @rkotkiewicz! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Sep 29, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Set mandatory defaults for the dockerfileZip task

Before this PR

If we don't apply the distribution plugin, dockerfileZip breaks a build.

After this PR

dockerfileZip don't break builds.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from carterkozak September 29, 2021 20:58
@rkotkiewicz
Copy link
Author

solves: #471

@rkotkiewicz rkotkiewicz marked this pull request as draft October 1, 2021 15:04
@rkotkiewicz rkotkiewicz marked this pull request as ready for review October 4, 2021 19:17
@stale
Copy link

stale bot commented Jan 8, 2022

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Jan 8, 2022
@stale stale bot closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants