Basic check for insecure curl/wget requests #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRogers
reviewed
Nov 13, 2024
Comment on lines
32
to
33
| List<String> lines = Files.readAllLines(Path.of("src/main/resources/gradle-jdks-functions.sh")); | ||
| for (String line : lines) { |
There was a problem hiding this comment.
I think we can just File.readString here and match on the whole string?
CRogers
reviewed
Nov 13, 2024
changelog/@unreleased/pr-464.v2.yml
Outdated
| @@ -0,0 +1,5 @@ | |||
| type: fix | |||
| fix: | |||
| description: Basic check for insecure curl/wget requests | |||
There was a problem hiding this comment.
Probably don't need changelog or a release for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
Extra checks that would avoid bugs like here: https://github.com/palantir/gradle-jdks/pull/452/files#diff-eab8ad98fab9b4edb9ec2349b5d7a41d5c93bf016e9f409511c6ef497d8c2facR146 where insecure flags were introduced in curl requests
==COMMIT_MSG==
Basic check for insecure curl/wget requests
==COMMIT_MSG==
Possible downsides?