Lock jdk creation using file locks #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunatley this is difficult to test.
Generate changelog in
|
|
The build failed due to this plugin itself, on the issue I'm trying to fix |
CRogers
reviewed
Jun 27, 2022
CRogers
reviewed
Jun 27, 2022
| path.getParent().resolve(path.getFileName() + ".lock"), | ||
| StandardOpenOption.CREATE, | ||
| StandardOpenOption.WRITE)); | ||
| FileLock fileLock = channel.lock(); |
There was a problem hiding this comment.
Fancy - didn't know you could get process-level file locks like this. What does it do on windows/NTFS, out of curiosity?
There was a problem hiding this comment.
On windows, the in-process (non-fs lock) is actually unnecessary since unlike unix, locks aren't owned by entire processes! No reason to remove that lock, though, since it would only increase the code complexity. Ideally we could get windows tests running in #69, however there are some hurdles with pjf+checkstyle
CRogers
approved these changes
Jun 27, 2022
|
Released 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously concurrent requests for JDKs would result in parallel unpacks which fail in unexpected ways due to serial existence checks succeeding in parallel.
Unfortunately this is difficult to test.
==COMMIT_MSG==
Lock jdk creation using file locks
==COMMIT_MSG==
We'll leave around
<jdk-dir-name>.lockfiles in the jdks directory