Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention JDK requirements in README #84

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Marcono1234
Copy link
Contributor

Before this PR

The class files of this project are compiled with Java 17 as target version, but it is currently not documented.

After this PR

The minimum JDK version is documented

Not sure if for the generated code a minimum JDK version can be specified as well. It probably mostly depends on what builder methods users are calling. For example if they use TypeSpec#recordBuilder, then the generated code can not be compiled with JDK 8.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/javapoet, @Marcono1234! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

carterkozak
carterkozak previously approved these changes Oct 2, 2024
@carterkozak carterkozak dismissed their stale review October 2, 2024 13:55

pending cla

@Marcono1234
Copy link
Contributor Author

pending cla

I had hoped a CLA will not be necessary. I will probably sign it though, but I have some questions which I wrote to [email protected] a few days ago, and will wait for an answer first.

@carterkozak
Copy link
Contributor

Thanks! Let me know if you don’t hear back by next week, I can make sure things move along. I’m ooto until next Thursday, so my response time may be a bit slow in the meantime.

@Marcono1234
Copy link
Contributor Author

Marcono1234 commented Oct 24, 2024

It seems I haven't gotten any response yet. Maybe the e-mail address I had sent my questions from was a bit unusual, but the e-mail subject and body shouldn't have triggered any spam detection on Palantir's side I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants