Remove unused headers: X-B3-ParentSpanId and X-OrigSpanId
#778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`X-B3-ParentSpanId` isn't standard zipkin, and doesn't provide any data we don't already have. The parent span of an incoming request span is the value of the `X-B3-SpanId` header. There's no reason for additional header values. `X-OrigSpanId` is a custom header added to provide some amount of tracing functionality when traces aren't sampled, however it hasn't quite worked and isn't supported by alternative tracing engines.
Generate changelog in
|
|
@CRogers This PR should reduce some of the cruft discussed on palantir/witchcraft-java-logging#46 :-) |
jkozlowski
reviewed
Sep 16, 2021
| * | ||
| * @deprecated Use the variant without an originating span id | ||
| */ | ||
| @SuppressWarnings("InlineMeSuggester") |
There was a problem hiding this comment.
Error prone has an inlineme annotation to document replacements on undesirable call sites. We don’t want to automate this migration because there’s potentially other data that can be removed.
jkozlowski
approved these changes
Sep 16, 2021
|
Released 6.4.0 |
|
X-B3-ParentSpanId is absolutely a part of standard zipkin but it's only used in an older style of propagation, where the server doesn't make a new span but rather "joins" onto the span the client created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-B3-ParentSpanIdisn't standard zipkin, and doesn't provideany data we don't already have. The parent span of an incoming
request span is the value of the
X-B3-SpanIdheader. There'sno reason for additional header values.
X-OrigSpanIdis a custom header added to provide some amount oftracing functionality when traces aren't sampled, however it
hasn't quite worked and isn't supported by alternative tracing
engines.
==COMMIT_MSG==
Remove unused headers:
X-B3-ParentSpanIdandX-OrigSpanId==COMMIT_MSG==