Merge pull request #653 from palantir/fix-shadowed

Don't check parameters in call signatures

lib/tslint.d.ts

@@ -8,6 +8,7 @@ declare module Lint {
         protected visitBlock(node: ts.Block): void;
         protected visitBreakStatement(node: ts.BreakOrContinueStatement): void;
         protected visitCallExpression(node: ts.CallExpression): void;
+        protected visitCallSignature(node: ts.SignatureDeclaration): void;
         protected visitCaseClause(node: ts.CaseClause): void;
         protected visitClassDeclaration(node: ts.ClassDeclaration): void;
         protected visitCatchClause(node: ts.CatchClause): void;

src/language/walker/syntaxWalker.ts

@@ -48,6 +48,10 @@ module Lint {
             this.walkChildren(node);
         }
 
+        protected visitCallSignature(node: ts.SignatureDeclaration) {
+            this.walkChildren(node);
+        }
+
         protected visitCaseClause(node: ts.CaseClause) {
             this.walkChildren(node);
         }
@@ -310,6 +314,10 @@ module Lint {
                     this.visitCallExpression(<ts.CallExpression> node);
                     break;
 
+                case ts.SyntaxKind.CallSignature:
+                    this.visitCallSignature(<ts.SignatureDeclaration> node);
+                    break;
+
                 case ts.SyntaxKind.CaseClause:
                     this.visitCaseClause(<ts.CaseClause> node);
                     break;

src/rules/noShadowedVariableRule.ts

@@ -48,6 +48,10 @@ class NoShadowedVariableWalker extends Lint.BlockScopeAwareRuleWalker<ScopeInfo,
         this.visitBlock(node.block);
     }
 
+    public visitCallSignature(node: ts.SignatureDeclaration) {
+        // don't call super, we don't need to check parameter names in call signatures
+    }
+
     public visitFunctionType(node: ts.FunctionOrConstructorTypeNode) {
         // don't call super, we don't need to check names in function types
     }

test/files/rules/no-shadowed-variable.test.ts

@@ -109,3 +109,8 @@ interface FalsePositive3 {
     specular: (pos: number) => number;
     pos: number;
 }
+
+interface FalsePositive4<T, TResult> {
+    (parameters: T, runSynchonous: boolean): TResult;
+    (parameters: T, callback: (error: Error, result: TResult) => void): void;
+}