'no-multiple-variable-declaration' -> 'one-variable-per-declaration' …

…rename (#1198) (#1199)

README.md

@@ -242,7 +242,6 @@ A sample configuration file with all options is available [here](https://github.
 * `no-internal-module` disallows internal `module` (use `namespace` instead).
 * `no-invalid-this` disallows using the `this` keyword outside of classes.
     * `no-this-in-function-in-method` disallows using the `this` keyword in functions within class methods.
-* `no-multiple-variable-declaration` disallows multiple variable definitions in the same statement.
 * `no-namespace` disallows both internal `module`s and `namespace`, but allows ES6-style external modules.
     * `allow-declarations` allows `declare namespace ... {}` to describe external APIs.
 * `no-null-keyword` disallows use of the `null` keyword literal.
@@ -269,6 +268,7 @@ A sample configuration file with all options is available [here](https://github.
   * `"check-finally"` checks that `finally` is on the same line as the closing brace for the preceding `try` or `catch`.
   * `"check-open-brace"` checks that an open brace falls on the same line as its preceding expression.
   * `"check-whitespace"` checks preceding whitespace for the specified tokens.
+* `one-variable-per-declaration` disallows multiple variable definitions in the same statement.
 * `quotemark` enforces consistent single or double quoted string literals. Rule options (at least one of `"double"` or `"single"` is required):
     * `"single"` enforces single quotes.
     * `"double"` enforces double quotes.

src/rules/noMultipleVariableDeclarationRule.ts → src/rules/oneVariablePerDeclarationRule.ts

@@ -22,12 +22,12 @@ export class Rule extends Lint.Rules.AbstractRule {
     public static FAILURE_STRING = "Forbidden multiple variable definitions in the same statement";
 
     public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
-        const noMultipleVarWalker = new NoMultipleVariableDeclarationWalker(sourceFile, this.getOptions());
-        return this.applyWithWalker(noMultipleVarWalker);
+        const oneVarWalker = new OneVariablePerDeclarationWalker(sourceFile, this.getOptions());
+        return this.applyWithWalker(oneVarWalker);
     }
 }
 
-class NoMultipleVariableDeclarationWalker extends Lint.RuleWalker {
+class OneVariablePerDeclarationWalker extends Lint.RuleWalker {
     public visitVariableStatement(node: ts.VariableStatement) {
         const { declarationList } = node;
 

src/tsconfig.json

@@ -93,7 +93,6 @@
         "rules/noInferrableTypesRule.ts",
         "rules/noInternalModuleRule.ts",
         "rules/noInvalidThisRule.ts",
-        "rules/noMultipleVariableDeclarationRule.ts",
         "rules/noNamespaceRule.ts",
         "rules/noNullKeywordRule.ts",
         "rules/noReferenceRule.ts",
@@ -110,6 +109,7 @@
         "rules/noVarRequiresRule.ts",
         "rules/objectLiteralSortKeysRule.ts",
         "rules/oneLineRule.ts",
+        "rules/oneVariablePerDeclarationRule.ts",
         "rules/quotemarkRule.ts",
         "rules/radixRule.ts",
         "rules/semicolonRule.ts",

test/rules/one-variable-per-declaration/tslint.json

@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "one-variable-per-declaration": true
+  }
+}

test/tsconfig.json

@@ -90,7 +90,6 @@
         "../src/rules/noInferrableTypesRule.ts",
         "../src/rules/noInternalModuleRule.ts",
         "../src/rules/noInvalidThisRule.ts",
-        "../src/rules/noMultipleVariableDeclarationRule.ts",
         "../src/rules/noNamespaceRule.ts",
         "../src/rules/noNullKeywordRule.ts",
         "../src/rules/noReferenceRule.ts",
@@ -107,6 +106,7 @@
         "../src/rules/noVarRequiresRule.ts",
         "../src/rules/objectLiteralSortKeysRule.ts",
         "../src/rules/oneLineRule.ts",
+        "../src/rules/oneVariablePerDeclarationRule.ts",
         "../src/rules/quotemarkRule.ts",
         "../src/rules/radixRule.ts",
         "../src/rules/semicolonRule.ts",