no-implicit-dependencies: strip BOM before parsing JSON (#3362)

[no-log]
palantir · Oct 20, 2017 · ecaad8e · ecaad8e
1 parent fff81e7
commit ecaad8e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 1 deletion.
diff --git a/src/rules/noImplicitDependenciesRule.ts b/src/rules/noImplicitDependenciesRule.ts
@@ -115,7 +115,8 @@ function getDependencies(fileName: string, options: Options): Set<string> {
     const packageJsonPath = findPackageJson(path.resolve(path.dirname(fileName)));
     if (packageJsonPath !== undefined) {
         // don't use require here to avoid caching
-        const content = JSON.parse(fs.readFileSync(packageJsonPath, "utf8")) as PackageJson;
+        // remove BOM from file content before parsing
+        const content = JSON.parse(fs.readFileSync(packageJsonPath, "utf8").replace(/^\uFEFF/, "")) as PackageJson;
         if (content.dependencies !== undefined) {
             addDependencies(result, content.dependencies);
         }

diff --git a/test/rules/no-implicit-dependencies/default/bom/package.json b/test/rules/no-implicit-dependencies/default/bom/package.json
@@ -0,0 +1,5 @@
+{
+    "name": "bom",
+    "version": "1.0.0",
+    "dependencies": {}
+}
diff --git a/test/rules/no-implicit-dependencies/default/bom/test.ts.lint b/test/rules/no-implicit-dependencies/default/bom/test.ts.lint
@@ -0,0 +1,2 @@
+import * as ts from "typescript";
+                    ~~~~~~~~~~~~ [Module 'typescript' is not listed as dependency in package.json]
diff --git a/test/rules/no-implicit-dependencies/default/subdir/test.ts.lint b/test/rules/no-implicit-dependencies/default/subdir/test.ts.lint
@@ -2,6 +2,9 @@ import {assert} from 'chai';
                      ~~~~~~ [err % ('chai')]
 import foo from 'foo';
 
+import Foo from 'Foo';
+                ~~~~~ [err % ('Foo')]
+
 if (foo) {
     const common = require('common');
                            ~~~~~~~~ [err % ('common')]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		import * as ts from "typescript";
		~~~~~~~~~~~~ [Module 'typescript' is not listed as dependency in package.json]