Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add static type annotation to the source and tests. Passes with mypy strict, pyright basic, and pyright
--verifytypes
. Addpy.typed
marker and classifier.If
Attachment.data
is not given, an error is raised. The argument order is a bit weird, probalby because it makes more sense to read them in that order, but due to thatdata
can beNone
in the signature, but must not beNone
when actually used.If
Attachment.content_type
is not given, it is detected.mimetypes.guess_type
is used onfilename
if filename is given. If that returnsNone
,text/plain
is used ifdata
is a string, otherwiseapplication/octet-stream
is used. The code requirescontent_type
to be set, but would previously just fail when building the message. This detection seemed preferrable to an error.